Error: class.product.php calling method on boolean

EtienneWebCustoms · Jan 3rd 2017

Hi,

I'm using the HHG-Multistore CE, version 4.10.2 (latest available).

Internally, the ADO method SelectLimit is used, and then a RecordCount method is called to see how many were selected. However, if no records were selected (the query 'failed'), it will return false (instead of the result). This will result in the page not being able to render correctly (because it'll crash).

Therefore, in `core/classes/class.product.php:600`, I had to change

PHP: core/classes/class.product.php

if ($best_sellers->RecordCount() >= MIN_DISPLAY_BESTSELLERS) {

into

PHP: core/classes/class.product.php

if ($best_sellers && $best_sellers->RecordCount() >= MIN_DISPLAY_BESTSELLERS) {

HHGAG · Jan 3rd 2017

Hi,

PHP: core/vendor/adodb/adodb.inc.php

/**
* synonyms RecordCount and RowCount
*
* @return the number of rows or -1 if this is not supported
*/
function RecordCount() {
return $this->_numOfRows;
}

RecordCount returns an integer if there are no results:

Quote

core/classes/class.product.php:797:int 0

If you get an error, it's caused by an SQL error and not due missing records.

P.S.: Du kannst auch gerne auf Deutsch schreiben

EtienneWebCustoms · Jan 3rd 2017

The method RecordCount exists only for classes of type ADORecordSet. The SelectLimit method does not always return such a set, according to this page.

When it's caused by an SQL error (or missing tables, which could also be the cause of SQL errors), then that'd be a bug as well - since I'm using the default installation, and everything *should* work 'out of the box'.

HHGAG · Jan 3rd 2017

PHP: core/vendor/adodb/adodb.inc.php

/**
* Will select, getting rows from $offset (1-based), for $nrows.
* This simulates the MySQL "select * from table limit $offset,$nrows" , and
* the PostgreSQL "select * from table limit $nrows offset $offset". Note that
* MySQL and PostgreSQL parameter ordering is the opposite of the other.
* eg.
* SelectLimit('select * from table',3); will return rows 1 to 3 (1-based)
* SelectLimit('select * from table',3,2); will return rows 3 to 5 (1-based)
*
* Uses SELECT TOP for Microsoft databases (when $this->hasTop is set)
* BUG: Currently SelectLimit fails with $sql with LIMIT or TOP clause already set
*
* @param sql
* @param [offset] is the row to start calculations from (1-based)
* @param [nrows] is the number of rows to get
* @param [inputarr] array of bind variables
* @param [secs2cache] is a private parameter only used by jlim
* @return the recordset ($rs->databaseType == 'array')
*/
function SelectLimit($sql,$nrows=-1,$offset=-1, $inputarr=false,$secs2cache=0) {

Display More

It's an ADORecordSet until the query is buggy. We couldn't reproduce your case, so it would be better to get your Query. Do following change and post your built query:

PHP: core/classes/class.product.php

$best_sellers = $this->registry['db']->query_limit($best_sellers_query, MAX_DISPLAY_BESTSELLERS, -1, true);

change to:

PHP: core/classes/class.product.php

debug($best_sellers_query);
$best_sellers = $this->registry['db']->query_limit($best_sellers_query, MAX_DISPLAY_BESTSELLERS, -1, true);

reproduce your error and post shown query. Revert changes after then.

EtienneWebCustoms · Jan 3rd 2017

SQL

SELECT DISTINCT
p.products_id
FROM
products AS p
LEFT JOIN object_to_store AS o2s
ON p.products_id = o2s.object_id
AND o2s.object_type_id = 14
LEFT JOIN object_to_group AS o2g
ON p.products_id = o2g.object_id
AND o2g.object_type_id = 14
WHERE
p.products_status = 1
AND p.products_ordered > 0
AND (o2s.store_1 = 1 OR o2s.store_all = 1)
AND p.products_master_model = ""
ORDER BY
p.products_ordered DESC

Display More

To be precise, $best_sellers becomes false instead of ADORecordSet

Code

ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'p.products_ordered > 0 AND (o2s.store_1 = 1 OR o2s.store_all = 1) AND p.product' at line 1

HHGAG · Jan 3rd 2017

Ok, seams to be an older MySQL Version or Strict mode is activated.
Change

PHP: core/classes/class.product.php

$best_sellers_query = "
SELECT DISTINCT
p.products_id
FROM
" . TABLE_PRODUCTS . " AS p
LEFT JOIN " . TABLE_OBJECT_TO_STORE . " AS o2s
ON p.products_id = o2s.object_id
AND o2s.object_type_id = " . $this->registry['object'][$this->object_type] . "
LEFT JOIN " . TABLE_OBJECT_TO_GROUP . " AS o2g
ON p.products_id = o2g.object_id
AND o2g.object_type_id = " . $this->registry['object'][$this->object_type] . "
WHERE
p.products_status = 1
AND p.products_ordered > 0
" . $this->group_check() . "
" . $this->fsk_lock() . "
" . $this->store_check() . "
" . $no_slave_products . "
ORDER BY
p.products_ordered DESC";

Display More

to

PHP: core/classes/class.product.php

$best_sellers_query = "
SELECT DISTINCT
p.products_id
FROM
(" . TABLE_PRODUCTS . " AS p)
LEFT JOIN " . TABLE_OBJECT_TO_STORE . " AS o2s
ON p.products_id = o2s.object_id
AND o2s.object_type_id = " . $this->registry['object'][$this->object_type] . "
LEFT JOIN " . TABLE_OBJECT_TO_GROUP . " AS o2g
ON p.products_id = o2g.object_id
AND o2g.object_type_id = " . $this->registry['object'][$this->object_type] . "
WHERE
p.products_status = 1
AND p.products_ordered > 0
" . $this->group_check() . "
" . $this->fsk_lock() . "
" . $this->store_check() . "
" . $no_slave_products . "
ORDER BY
p.products_ordered DESC";

Display More

EtienneWebCustoms · Jan 3rd 2017

MySQL version 5.7.17
Strict-mode ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION

(The strict level was the default for my MySQL installation.)

Changing the parenthesis like you suggested unfortunately had no effect.

HHGAG · Jan 3rd 2017

Could you try this query, please

SQL

SELECT DISTINCT
`p`.`products_id`
FROM
`products` AS p
LEFT JOIN `object_to_store` AS o2s
ON `p`.`products_id` = `o2s`.`object_id`
AND `o2s`.`object_type_id` = 14
LEFT JOIN `object_to_group` AS o2g
ON `p`.`products_id` = `o2g`.`object_id`
AND `o2g`.`object_type_id` = 14
WHERE
`p`.`products_status` = 1
AND `p`.`products_ordered` > 0
AND (`o2s`.`store_1` = 1 OR `o2s`.`store_all` = 1)
AND `p`.`products_master_model` = ""
ORDER BY
`p`.`products_ordered` DESC

Display More

EtienneWebCustoms · Jan 3rd 2017

Okay, the Error 1064 (42000) was caused by a whitespace I removed - oops.

The actual error being:

Code

ERROR 3065 (HY000): Expression #1 of ORDER BY clause is not in SELECT list, references column 'hhg.p.products_ordered' which is not in SELECT list; this is incompatible with DISTINCT

HHGAG · Jan 3rd 2017

You should restore the origin file and if you have the error again, you could add the column to the select list.

Share